Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio descriptions are not computed #29825

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

LasseEmilHildebrandt
Copy link
Contributor

@LasseEmilHildebrandt LasseEmilHildebrandt commented Mar 7, 2023

Description

The different audio descriptions are not computed.

This results in a confusing 'creation-diff' that does not match with reality.

Empty audio_descriptions, will however have a default AAC encoding. This is not reflected in the schema changes.

Relations

Relates #27824

References

Output from Acceptance Testing

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Hey @LasseEmilHildebrandt 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/medialive Issues and PRs that pertain to the medialive service. size/XS Managed by automation to categorize the size of a PR. and removed service/medialive Issues and PRs that pertain to the medialive service. labels Mar 7, 2023
@LasseEmilHildebrandt
Copy link
Contributor Author

Hey @LasseEmilHildebrandt 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

We are aware of this issue, and are currently unable to resolve it.

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. service/medialive Issues and PRs that pertain to the medialive service. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_'  -timeout 180m
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (83.61s)
--- PASS: TestAccMediaLiveChannel_disappears (85.58s)
--- PASS: TestAccMediaLiveChannel_hls (86.48s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (97.63s)
--- PASS: TestAccMediaLiveChannel_updateTags (111.66s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (150.19s)
--- PASS: TestAccMediaLiveChannel_basic (164.89s)
--- PASS: TestAccMediaLiveChannel_update (207.33s)
--- PASS: TestAccMediaLiveChannel_status (274.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	277.356s

@johnsonaj
Copy link
Contributor

@LasseEmilHildebrandt thanks for the contribution! 🎉

@johnsonaj johnsonaj merged commit 7e0beef into hashicorp:main Mar 16, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 16, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@LasseEmilHildebrandt LasseEmilHildebrandt deleted the b-audio_encodes_are_not_computed branch March 17, 2023 07:40
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/medialive Issues and PRs that pertain to the medialive service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants